Refactor instruments #216
Closed
Refactor instruments #216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ns across multiple files
…move outdated comments
… to include get_instruments method
…edule and ShipConfig classes
j-atkins
force-pushed
the
instrument-refactor
branch
from
bbfaf8b to
c4ddea1
Compare
j-atkins
requested review from
VeckoTheGecko
and removed request for
VeckoTheGecko
j-atkins
force-pushed
the
instrument-refactor
branch
from
46140e9 to
a5d10e7
Compare
for more information, see https://pre-commit.ci
…ship into instrument-refactor
…emove unused function
* add code of conduct to assignments * fix thumbnails
* add teacher info to documentation * incoporate review suggestions * fix default thumbnail * change ILOs to ipynb --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
j-atkins
force-pushed
the
instrument-refactor
branch
from
54a1be3 to
56d8fd5
Compare
j-atkins
force-pushed
the
instrument-refactor
branch
from
5fb9c66 to
eaa124c
Compare
…ormance evaluation
…n() to Instrument.execute()
j-atkins
force-pushed
the
instrument-refactor
branch
from
1535abe to
10e68b3
Compare
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR focuses on refactoring logic for input dataset fetching by consolidating into a base
InputDatasetclass and a child class (e.g.CTDInputDataset) per instrument, in line with V1 aims.This new model and instrument classes are now also used in
virtualship fetchto reduce the amount of repeated logic there. This also works towards reducing the number of areas in the codebase where instrument-related logic is defined. A future PR will continue this by refactoring the instrument simulation logic in the same base class -> child class fashion.